Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the polynomial regular expression to remove the ambiguity #2135

Merged
merged 3 commits into from
May 14, 2024

Conversation

AnastasiiaSvietlova
Copy link
Contributor

Goal

Modify the regular expression to remove the ambiguity, or ensure that the strings matched with the regular expression are short enough that the time-complexity does not matter.

Changeset

Updated RegExp and added .trim() for trimming whitespaces in ret

Testing

Covered by existing unit test

Copy link

github-actions bot commented May 13, 2024

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.80 kB 13.43 kB
After 43.80 kB 13.43 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 381ed78

@AnastasiiaSvietlova AnastasiiaSvietlova marked this pull request as ready for review May 13, 2024 14:11
CHANGELOG.md Outdated
@@ -1,5 +1,11 @@
# Changelog

## TBD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## TBD
## [Unreleased]

@AnastasiiaSvietlova AnastasiiaSvietlova merged commit 4a30e63 into next May 14, 2024
55 checks passed
@AnastasiiaSvietlova AnastasiiaSvietlova deleted the PLAT-11322-polynomial-regular-expression branch May 14, 2024 06:48
@yousif-bugsnag yousif-bugsnag mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants