Report signal codes on native crashes #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
lemnik
reviewed
Jan 28, 2025
bugsnag-plugin-android-ndk/src/main/jni/handlers/signal_handler.c
Outdated
Show resolved
Hide resolved
bugsnag-plugin-android-ndk/src/main/jni/handlers/signal_handler.c
Outdated
Show resolved
Hide resolved
bugsnag-plugin-android-ndk/src/main/jni/handlers/signal_handler.c
Outdated
Show resolved
Hide resolved
6f64902 to
21ac005
Compare
23f1dcc to
a655d1c
Compare
…signal_code_names
…signal_code_names
…acros to reduce possible mistakes
a655d1c to
3d56381
Compare
lemnik
approved these changes
Jan 29, 2025
lemnik
approved these changes
Jan 30, 2025
tomlongridge
approved these changes
Jan 30, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Show corresponding signal code for native crashes
Changeset
Added a table of signal code descriptions for error messages, covering all of the defined signal codes. Having all of the messages pre-generated (via a macro) we avoid possible overflows and undefined behaviour that could occur when generating the error message from within the signal handler.
Testing
Existing e2e tests