Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license-check and release to the bugsnag-android module #2125

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Add license-check and release to the bugsnag-android module #2125

merged 1 commit into from
Jan 17, 2025

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Jan 17, 2025

Goal

Correct the release scripts (adding the release script to the bugsnag-android meta-module).

Testing

Tested with local publishing

@lemnik lemnik requested a review from joshedney January 17, 2025 15:52
@lemnik lemnik requested a review from YYChen01988 as a code owner January 17, 2025 15:52
@lemnik lemnik requested a review from tomlongridge January 17, 2025 15:52
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1872.24 1675.95
arm64_v8a 651.52 450.82
armeabi_v7a 585.99 385.29
x86 725.23 528.62
x86_64 696.57 495.86

Generated by 🚫 Danger

YYChen01988
YYChen01988 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@YYChen01988 YYChen01988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemnik lemnik merged commit 0ac2816 into next Jan 17, 2025
34 checks passed
@lemnik lemnik deleted the lemnik/fix-release-script branch January 17, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YYChen01988 YYChen01988 YYChen01988 approved these changes

@joshedney joshedney Awaiting requested review from joshedney

@tomlongridge tomlongridge Awaiting requested review from tomlongridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemnik @bugsnagbot @YYChen01988