Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the correlation field for ReactNative #2050

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Add support for the correlation field for ReactNative #2050

merged 1 commit into from
Jul 1, 2024

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Jun 28, 2024

Goal

Allow ReactNative apps to add correlation metadata to Events

Changeset

Attempt to decode and set the traceId & correlationId when they are both available and valid.

Testing

Added new fields to the existing unit tests

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jun 28, 2024 •
edited
Loading

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1852.59 1674.82
arm64_v8a 631.04 450.82
armeabi_v7a 565.51 385.29
x86 704.75 528.62
x86_64 676.09 495.86

Generated by 🚫 Danger

@lemnik lemnik force-pushed the PLAT-12387/rn-correlation branch from fcb4a47 to 95e7a6e Compare June 28, 2024 15:39
@lemnik lemnik merged commit 10bc93e into next Jul 1, 2024
26 checks passed
@lemnik lemnik deleted the PLAT-12387/rn-correlation branch July 1, 2024 10:33
This was referenced Jul 3, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gingerbenw gingerbenw gingerbenw approved these changes

@tomlongridge tomlongridge Awaiting requested review from tomlongridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemnik @bugsnagbot @gingerbenw