Don't use strings for BreadcrumbType
in NDK
#2018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Small reduction in overhead when leaving breadcrumbs: use integers to represent the
BreadcrumbType
instead of strings.Design
While the string values for
BreadcrumbType
on the Java/Kotlin code were constants, they required a call toGetStringUTFChars
andstrcmp
to evaluate which enum value to use.The new implementation uses an exhaustive
when
which means:enum
values (asordinal
would be)enum
values will cause compiler failuresTesting
Relied on existing tests.