Reduce use of Atomics in Session #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
5aad846 to
f4db119
Compare
lemnik
reviewed
Apr 16, 2024
bugsnag-android-core/src/main/java/com/bugsnag/android/Session.java
Outdated
Show resolved
Hide resolved
… boolean since it does not use specific atomic method
f4db119 to
a96b03a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Reduce use of Atomics in Session, so the value is more accurate syncing between multiple threads.
Changeset
Change autoCaptured type from AtomicBoolean to volatile boolean since it does not use specific atomic method.