-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process importance in app metadata #1973
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
lemnik
reviewed
Feb 6, 2024
bugsnag-android-core/src/main/java/com/bugsnag/android/AppDataCollector.kt
Outdated
Show resolved
Hide resolved
698d24d
to
afda1b2
Compare
c27f836
to
792ce71
Compare
e0f74b9
to
9c6d561
Compare
lemnik
requested changes
Feb 7, 2024
bugsnag-android-core/src/main/java/com/bugsnag/android/AppDataCollector.kt
Outdated
Show resolved
Hide resolved
9c6d561
to
a541598
Compare
lemnik
reviewed
Feb 7, 2024
bugsnag-android-core/src/main/java/com/bugsnag/android/AppDataCollector.kt
Outdated
Show resolved
Hide resolved
lemnik
reviewed
Feb 7, 2024
bugsnag-android-core/src/main/java/com/bugsnag/android/AppDataCollector.kt
Outdated
Show resolved
Hide resolved
bugsnag-android-core/src/androidTest/java/com/bugsnag/android/AppDataCollectorTest.kt
Outdated
Show resolved
Hide resolved
e8da44d
to
bc7a706
Compare
lemnik
reviewed
Feb 7, 2024
bugsnag-android-core/src/main/java/com/bugsnag/android/AppDataCollector.kt
Outdated
Show resolved
Hide resolved
bc7a706
to
102b5d5
Compare
lemnik
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Displayed process improtance in
Bugsnag app
on dashboardChangeset
Added processImportance to app metadata
Testing
Introduce new unit test and manual test