Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record process importance for jvm android errors #1968

Merged
8 commits merged into from
Feb 2, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 30, 2024

Goal

Introduce application exit reason and process importance to BugSnag-ExitInfo Plugin for android 11+ devices and displayed on dashboard under metadata app.

Changeset

Decoded application exit reason and process importance to strings for app metadata

Testing

New unit tests and end to end test

…ance_for_JVM_Android_errors' into PLAT-11478/record_process_importance_for_JVM_Android_errors

# Conflicts:
#	bugsnag-plugin-android-exitinfo/src/main/java/com/bugsnag/android/ExitInfoCallback.kt
@ghost ghost requested a review from lemnik January 30, 2024 15:50
@ghost ghost changed the title Plat 11478/record process importance for jvm android errors PLAT-11478/record process importance for jvm android errors Jan 30, 2024
@ghost ghost changed the title PLAT-11478/record process importance for jvm android errors Record process importance for jvm android errors Jan 30, 2024
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jan 30, 2024

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1842.17 1668.27
arm64_v8a 626.95 450.82
armeabi_v7a 561.42 385.29
x86 700.66 524.53
x86_64 671.99 495.86

Generated by 🚫 Danger

@ghost ghost force-pushed the PLAT-11478/record_process_importance_for_JVM_Android_errors branch from 804a370 to 4ea7035 Compare January 30, 2024 15:58
@ghost ghost force-pushed the PLAT-11478/record_process_importance_for_JVM_Android_errors branch 2 times, most recently from 4fffa33 to c2bd70d Compare January 30, 2024 17:05
@ghost ghost force-pushed the PLAT-11478/record_process_importance_for_JVM_Android_errors branch 2 times, most recently from 4c6bd25 to 42ee9a0 Compare January 31, 2024 09:01
@ghost ghost requested a review from lemnik January 31, 2024 09:02
@ghost ghost force-pushed the PLAT-11478/record_process_importance_for_JVM_Android_errors branch from 42ee9a0 to b71e94a Compare January 31, 2024 09:06
@ghost ghost force-pushed the PLAT-11478/record_process_importance_for_JVM_Android_errors branch 2 times, most recently from c965c9c to 8d861bd Compare January 31, 2024 11:56
@ghost ghost requested a review from lemnik January 31, 2024 12:36
@ghost ghost force-pushed the PLAT-11478/record_process_importance_for_JVM_Android_errors branch from 8d861bd to 4fa0611 Compare February 2, 2024 10:31
@ghost ghost requested a review from lemnik February 2, 2024 10:32
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit bbb30d5 into next Feb 2, 2024
27 checks passed
@ghost ghost deleted the PLAT-11478/record_process_importance_for_JVM_Android_errors branch February 2, 2024 11:38
@ghost ghost mentioned this pull request Feb 8, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants