Handle NaN & Infinity values in serialization #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
tomlongridge
approved these changes
Dec 19, 2023
…a`, `breadcrumbs`, and `featureFlags` to be missing from the marshalled JSON without causing a deserialization failure
14a006d to
dcb3b12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoid creating invalid / incomplete event payloads when metadata includes non-finite values (typically via ReactNative).
Design
The non-finite double values (
NaN,-Infinityand+Infinity) are now omitted (along with any associated keys) instead of throwing anIllegalArgumentExceptionTesting
Adjusted the existing unit tests.