Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time limitation for thread collection (V5 backport) #1952

Merged
1 commit merged into from
Dec 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 5, 2023

Goal

Users is able to set a maximum time to avoid the timeout while collecting threads

Changeset

Adding a maximum traces time variable in config that allow setting a time limitation while capturing threads.

Testing

Introduce new unit test and existing unit tests

@ghost ghost requested a review from lemnik December 5, 2023 14:32
@ghost ghost force-pushed the PLAT-11267/thread-collection-time-limitation branch from f999a18 to 77c3a3a Compare December 5, 2023 14:33
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1898.9 1667.67
arm64_v8a 676.1 450.82
armeabi_v7a 614.66 385.29
x86 753.9 524.53
x86_64 725.24 495.86

Generated by 🚫 Danger

Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 6ef2700 into v5/next Dec 12, 2023
2 checks passed
@ghost ghost deleted the PLAT-11267/thread-collection-time-limitation branch December 12, 2023 09:07
@ghost ghost mentioned this pull request Dec 12, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants