Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent payload #1949

Merged
8 commits merged into from
Nov 28, 2023
Merged

Consistent payload #1949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2cd05dd
fix(payload size) added error call back to make the payload size more…
YYChen01988 Nov 24, 2023
50d9127
Convert file store and subclasses to kotlin (#1929)
Nov 24, 2023
1a25f27
fix(payload size) added error call back to clear threads
Nov 24, 2023
14a73c9
Merge branch 'next' into PLAT-11176/consistent-payload-in-e2e-tests
Nov 27, 2023
6be1acc
Time limitation for thread collection (#1935)
Nov 27, 2023
9200853
Feature flags should be modified in-place. (#1940)
Nov 27, 2023
1cb9338
Merge branch 'next' into PLAT-11176/consistent-payload-in-e2e-tests
Nov 27, 2023
f2c6821
fix(payload size) adjusted end to end test
Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ios-bugsnag/src/main/java/com/bugsnag/android/mazerunner/scenarios/EventTooBigScenario.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ class EventTooBigScenario(
breadcrumbCount = args[2].toInt()
config.setTelemetry(config.getTelemetry() + Telemetry.USAGE)
}
// Remove all threads from the error as the stack traces vary in size enough to trigger
// different trimming behavior, and cause the scenarios to fail
config.addOnError { event ->
event.threads.clear()
true
}
}

external fun nativeCrash(value: Int): Int
Expand Down
12 changes: 6 additions & 6 deletions features/full_tests/trimming.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,15 @@ Feature: Excess data is trimmed when the payload is too big
Then I wait to receive an error
And the error is valid for the error reporting API version "4.0" for the "Android Bugsnag Notifier" notifier
And the exception "message" equals "EventTooBigScenario"
And the event has less than 99 breadcrumbs
And the event has less than 100 breadcrumbs
Then the event last breadcrumb has a message that matches the regex "Removed, along with [0-9]+ older breadcrumbs, to reduce payload size"
And the event "usage.system.breadcrumbsRemoved" is not null
And the event "usage.system.breadcrumbBytesRemoved" is not null
And I close and relaunch the app
Then I wait to receive an error
And the error is valid for the error reporting API version "4.0" for the "Android Bugsnag Notifier" notifier
And the exception "message" equals "EventTooBigScenario"
And the event has less than 99 breadcrumbs
And the event has less than 100 breadcrumbs
Then the event last breadcrumb has a message that matches the regex "Removed, along with [0-9]+ older breadcrumbs, to reduce payload size"
And the event "usage.system.breadcrumbsRemoved" is not null
And the event "usage.system.breadcrumbBytesRemoved" is not null
Expand All @@ -75,7 +75,7 @@ Feature: Excess data is trimmed when the payload is too big
Then I wait to receive an error
And the error is valid for the error reporting API version "4.0" for the "Android Bugsnag Notifier" notifier
And the exception "message" equals "EventTooBigScenario"
And the event has less than 99 breadcrumbs
And the event has less than 100 breadcrumbs
Then the event last breadcrumb has a message that matches the regex "Removed, along with [0-9]+ older breadcrumbs, to reduce payload size"
And the event "usage.system.breadcrumbsRemoved" is not null
And the event "usage.system.breadcrumbBytesRemoved" is not null
Expand All @@ -88,9 +88,9 @@ Feature: Excess data is trimmed when the payload is too big
Then I wait to receive an error
And the error is valid for the error reporting API version "4.0" for the "Android Bugsnag Notifier" notifier
And the exception "message" equals "Empty list doesn't contain element at index 0."
And the event has 98 breadcrumbs
And the event "breadcrumbs.97.name" equals "Removed, along with 2 older breadcrumbs, to reduce payload size"
And the event "usage.system.breadcrumbsRemoved" equals 3
And the event has 99 breadcrumbs
And the event "breadcrumbs.98.name" equals "Removed, along with 1 older breadcrumbs, to reduce payload size"
And the event "usage.system.breadcrumbsRemoved" equals 2
And the event "usage.system.breadcrumbBytesRemoved" is not null

# Note: Disabled until native hard limits are removed.
Expand Down