Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are consumer ProGuard rules included? #107

Closed
JakeWharton opened this issue May 2, 2016 · 3 comments
Closed

Why are consumer ProGuard rules included? #107

JakeWharton opened this issue May 2, 2016 · 3 comments

Comments

@JakeWharton
Copy link
Contributor

As far as I can tell none of them are needed. This library has no reflection so both obfuscation and stripping will behave correctly without them.

Currently it disables both obfuscation and stripping without a clear reason as to why.

@JakeWharton
Copy link
Contributor Author

From the history it looks like these rules were once used to ProGuard the release jar and erroneously were converted to consumer rules?

Unless someone sees something that I don't, these should be removed to allow obfuscation and unused code stripping.

@JakeWharton
Copy link
Contributor Author

Having manually removed the embedded proguard rules, everything still works fine and allowed 77 methods to be removed as well as obfuscation to occur.

I'm sending a PR.

@kattrali
Copy link
Contributor

They were used at one point, but that has long since passed. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants