-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why are consumer ProGuard rules included? #107
Comments
From the history it looks like these rules were once used to ProGuard the release jar and erroneously were converted to consumer rules? Unless someone sees something that I don't, these should be removed to allow obfuscation and unused code stripping. |
Having manually removed the embedded proguard rules, everything still works fine and allowed 77 methods to be removed as well as obfuscation to occur. I'm sending a PR. |
They were used at one point, but that has long since passed. Merging. |
As far as I can tell none of them are needed. This library has no reflection so both obfuscation and stripping will behave correctly without them.
Currently it disables both obfuscation and stripping without a clear reason as to why.
The text was updated successfully, but these errors were encountered: