Delete the --strict flag of the conformance runner #334
+80
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
rodaine
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
--strictflag, the conformance harness requires that a Protovalidate implementation under test produces the expected number of violations, and that the fieldsconstraint_id,field, andruleof each Violation match.Without the flag, the harness is likely to return false positives. For example, a broken implementation that simply always returns a single empty Violation, passes 43% of the tests:
This concrete example is unlikely to happen in practice, but it illustrates that it's awfully easy for bugs to slip in without
--strict. I'm sure the situation was different at some point in time, but with the current suite of tests, it appears to be wise to make--strictthe default behavior before we cut a v1.This PR deletes the flag, which is a breaking change for users of the test harness. The Java, Go, C++, and Ruby implementations all set the flag. They will have to remove the flag, but are otherwise unaffected. I'm happy to hide the flag instead, but removing it seemed like a clean cut.