Temporarily revert updates to the documentation in validate.proto #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
7d3afda to
d6d2b4c
Compare
pkwarren
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #320, we've update the definitions for the protovalidate CEL functions: We've added conformance tests to clarify the behavior, and updated the comments for the standard constraints accordingly.
To update all protovalidate implementations, we want to cut a release so that we can use the conformance test suite. But we don't want to ship the updated comments in validate.proto at this point, because they wouldn't be accurate yet.
So this PR reverts the changes to the comments in validate.proto made in #320. They will be restored once we're ready to ship the updated implementations.