Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when processing conformance results #326

Merged

Conversation

timostamm
Copy link
Member

@timostamm timostamm commented Mar 5, 2025

Conformance test cases can be invalid: For example, they can define a bad field path, or a message that fails to marshal.

If such a test case slips in, the conformance runner silently stops processing at a random point.

This updates the runner to fail with an error instead.

Copy link

github-actions bot commented Mar 5, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 5, 2025, 6:16 PM

@timostamm timostamm added the Conformance Related to the conformance testing cases or harness label Mar 5, 2025
@timostamm timostamm merged commit df9ad5c into main Mar 5, 2025
10 checks passed
@timostamm timostamm deleted the tstamm/Return-error-when-processing-conformance-results branch March 5, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Conformance Related to the conformance testing cases or harness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants