Skip to content

Commit

Permalink
Print unexpected success cases in the conformance runner (#335)
Browse files Browse the repository at this point in the history
  • Loading branch information
timostamm authored Mar 11, 2025
1 parent 19dee1a commit 0e59ac3
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tools/protovalidate-conformance/internal/results/set.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ func (suite *SuiteResults) AddCase(res *harness.CaseResult, verbose bool) {
default:
suite.Failures++
}
if verbose || (!res.GetSuccess() && !res.GetExpectedFailure()) {
unexpectedFailure := !res.GetSuccess() && !res.GetExpectedFailure()
unexpectedSuccess := res.GetSuccess() && res.GetExpectedFailure()
if verbose || unexpectedFailure || unexpectedSuccess {
suite.Cases = append(suite.Cases, res)
}
}
Expand Down

0 comments on commit 0e59ac3

Please sign in to comment.