fix: don't use .fromBinary on import #681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
timostamm
reviewed
Jan 29, 2024
timostamm
reviewed
Jan 29, 2024
| const r = inject(content, ` "${defaults.toString("base64url")}" `); | ||
| const base64String = defaults.toString("base64url"); | ||
| const buffer = protoBase64.dec(base64String); | ||
| const featureSetDefaults = FeatureSetDefaults.fromBinary(buffer); |
There was a problem hiding this comment.
Depending on our own runtime can be an issue here, because we need this package to bootstrap it 😓
I'm not completely sure it'll be problem in practice now or in the future, but I'm sure that not using our own runtime within this helper package avoids the problem 100% 🙂
There was a problem hiding this comment.
Yep I did think about it, but as we only depend on some google types, it didn't seem to be an issue. However I do agree it's best to avoid it :)
|
Superseded by #683, but thanks for the PR ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #680, by transforming the b64 feature set to a JSON string describing the message, at buildtime (bootstrap step /
npm run -w packages/protobuf bootstrap:featureset-defaults).This allows to import
@bufbuild/protobufin a context that doesn't provide aTextEncoderglobally.Please let me know if you have any feedback :)