Make toPlainMessage idempotent
#588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
timostamm
reviewed
Oct 13, 2023
Signed-off-by: Andrew Haines <andrew@haines.org.nz>
c302eb6 to
0d0fa90
Compare
|
Thanks! |
Merged
|
This was just released in v1.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to call
toPlainMessageon aPlainMessage<T>object as well as aMessage<T>instance.The motivation for this change is the lack of exact types in TypeScript. Specifically, if I define a function that accepts a
PlainMessage<T>as an argument, it's valid to pass aMessage<T>instance as well, because it has all the properties necessary to satisfy thePlainMessage<T>interface.If I need to ensure that I actually have a
PlainMessage<T>inside the function (e.g. for the reasons described in connectrpc/connect-es#505), at the moment I have to type the parameter asT | PlainMessage<T>, and check withinstanceof Messagebefore callingtoPlainMessage.