Add strict option to v1 #1043
Open
Add strict option to v1 #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #414
This PR adds a
strictoption to protoc-gen-es v1 to allow forrequiredlabels in proto2 syntax to be reflected as actually required fields.All current tests pass with
strict=0(which is of course the default), so there should be no breaking changes.In order to facilitate type checking for strict mode there's a new
PartialStrictMessagetype that enforces required fields to be part of the initial message constructor.Would highly appreciate if you considered adding this option. I tried to make it non breaking and as useful as possible for others.