Update to google protobuf v29.2 #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
commented
Dec 18, 2024
| @@ -812,3 +812,17 @@ Required.Proto3.TextFormatInput.Uint64FieldMaxValueOctal.TextFormatOutput | |||
| Required.Proto3.TextFormatInput.Uint64FieldTooLarge | |||
| Required.Proto3.TextFormatInput.Uint64FieldTooLargeHex | |||
| Required.Proto3.TextFormatInput.Uint64FieldTooLargeOctal | |||
| Required.Editions_Proto2.TextFormatInput.ClosedEnumFieldByNumber.ProtobufOutput # Failed to parse input or produce output. | |||
There was a problem hiding this comment.
Skip new text format conformance tests - we do not implement the text format.
| @@ -70,7 +70,7 @@ describe("editions support in plugins", () => { | |||
| generateAny() {}, | |||
| }); | |||
| expect(res.minimumEdition).toBe(minimumEdition); | |||
| expect(res.minimumEdition).toBe(minimumEdition); | |||
| expect(res.maximumEdition).toBe(maximumEdition); | |||
There was a problem hiding this comment.
This test is supposed to verify min and max edition, but it was testing min twice. This fixes the test.
Comment on lines
+75
to
+78
| /** | ||
| * Enable compiling unreleased editions in protoc (undocumented flag `--experimental_editions`). | ||
| */ | ||
| experimentalEditions?: boolean; |
There was a problem hiding this comment.
Edition 2024 is unreleased and hidden behind the --experimental_editions flag in protoc. Adding this option because I took a peek.
smaye81
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.