-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against globalThis
not being defined
#486
Comments
Hi @lukasIO. This is probably more of an issue that should be fixed with Samsung Internet 9.2. |
hi @smaye81 , I opened #488 with the one-line fix that would be needed to make it ES2017 compatible. |
fixes #486 --------- Co-authored-by: Steve Ayers <sayers@buf.build>
Hi!
https://github.com/bufbuild/protobuf-es/blob/main/packages/protobuf/src/proto-int64.ts#L121
checks directly on
globalThis
for BigInt support. But globalThis might be undefined itself (https://caniuse.com/?search=globalthis).For the most part it seems as soon as
BigInt
is supported, globalThis should also be supported, only Samsung Internet rains on the parade.I guess a naive option (ignoring BigInt support of Samsung Internet 9.2) would be to add a
typeof globalThis !== undefined
before the BigInt check.The text was updated successfully, but these errors were encountered: