-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import aliases for packages whose name doesn't match import path #22
Conversation
Hi, @zchee, thanks for opening a pull request! But I'm afraid the existing gci configuration is intentional. The current import grouping (just two groups) is consistent with other bufbuild repos (like bufbuild/buf and bufbuild/connect-go). |
@jhump Ah, I see. That's the bufbuild code style. I respect it. So, I changed PR about |
I think import alias also not bufbuild style. Close. |
@zchee, sorry I didn't reply to this. I got pulled into something late last week and have been kind of heads down for a while. I was still considering this pull request. My main concern with merging it is that it won't last very long: as the code is edited and new imports are added, things will change and the aliases may be lost. I think the intent is completely reasonable. But I also think we need some way to check/enforce it in CI if we want these aliases to be preserved over time. If there's a way to make |
@jhump Nop! I'll re-open PR with that later, Thanks! |
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@jhump PTAL |
Signed-off-by: Koichi Shiraishi <zchee.io@gmail.com>
@jhump Thanks!! |
@jhump Would you like to send this change to another repository by me? |
For code readability.