Update buf registry login to use browser by default #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the command `buf registry login` to use the brower login flow. Users will be prompted to complete the flow in the browser authorizing the device and providing it an access token.
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
reviewed
Jul 29, 2024
emcfarlane
commented
Jul 29, 2024
mfridman
reviewed
Jul 31, 2024
mfridman
reviewed
Jul 31, 2024
doriable
approved these changes
Aug 1, 2024
bufdev
reviewed
Aug 1, 2024
private/buf/cmd/buf/command/registry/registrylogin/registrylogin.go
Outdated
Show resolved
Hide resolved
private/buf/cmd/buf/command/registry/registrylogin/registrylogin.go
Outdated
Show resolved
Hide resolved
private/buf/cmd/buf/command/registry/registrylogin/registrylogin.go
Outdated
Show resolved
Hide resolved
| var ( | ||
| // ErrUnsupported is returned when we receive an unsupported response from the server. | ||
| // | ||
| // TODO(go1.21): replace by errors.ErrUnsupported once it is available. |
There was a problem hiding this comment.
Once this PR is merged, make sure to merge main into #3123 and delete this
bufdev
reviewed
Aug 1, 2024
private/buf/cmd/buf/command/registry/registrylogin/registrylogin.go
Outdated
Show resolved
Hide resolved
bufdev
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the command
buf registry loginto use the brower login flow. On login, the users browser will be opened prompting the user to approve or deny access to the device. This simplifies the login flow avoiding the steps previously required to create an access token before providing it to the CLI.The flag
--no-browsermay be provided to disable the browser flow and prompt the user for the access token. The flag--token-stdinbehaviour remains the same as before. Providing both flags is an error.