Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from internal #110

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Fixes from internal #110

merged 1 commit into from
Jul 14, 2020

Conversation

bufdev
Copy link
Member

@bufdev bufdev commented Jul 14, 2020

  • Fixes issue where Zsh completion would fail due to some flags having brackets in their description. This is done via upgrading spf13/cobra to master for now via Square brackets in the description causes problems with zsh spf13/cobra#1129. Fixes Zsh/Fish completion failing #105.
  • Fixes issue where non-builtin protoc plugin invocations would not have errors properly propagated.
  • Fixes issue where multiple --.*_opt flags, --.*_opt flags with commas, or --.*_out flags with options that contained commas, would not be properly added.
  • Dogfoods protoc --by_dir flag.

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #110 into master will decrease coverage by 0.05%.
The diff coverage is 55.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   73.04%   72.98%   -0.06%     
==========================================
  Files         179      179              
  Lines       10647    10668      +21     
==========================================
+ Hits         7777     7786       +9     
- Misses       2114     2123       +9     
- Partials      756      759       +3     
Impacted Files Coverage Δ
internal/buf/cmd/buf/buf.go 0.00% <ø> (ø)
internal/buf/cmd/buf/internal/protoc/errors.go 8.16% <0.00%> (+4.08%) ⬆️
internal/pkg/app/appproto/appproto.go 53.84% <ø> (ø)
...al/pkg/app/appproto/appprotoexec/binary_handler.go 67.39% <0.00%> (-4.71%) ⬇️
internal/pkg/app/appproto/response_writer.go 65.11% <35.71%> (-14.89%) ⬇️
internal/buf/cmd/buf/internal/protoc/flags.go 80.28% <78.26%> (+1.81%) ⬆️
internal/buf/cmd/buf/internal/protoc/plugin.go 52.85% <100.00%> (ø)
internal/buf/bufanalysis/bufanalysis.go 66.31% <0.00%> (-2.11%) ⬇️
internal/buf/bufcheck/internal/config.go 74.69% <0.00%> (-1.21%) ⬇️
internal/pkg/fetch/ref_parser.go 92.89% <0.00%> (-0.95%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bbf2eb...41b8c12. Read the comment docs.

@bufdev bufdev merged commit 8011426 into master Jul 14, 2020
@bufdev bufdev deleted the fixes branch July 14, 2020 16:36
Monirul1 pushed a commit to Monirul1/buf that referenced this pull request Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zsh/Fish completion failing
1 participant