Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zsh autocompletion #106

Closed
wants to merge 1 commit into from
Closed

Conversation

amenzhinsky
Copy link

Fixes: #105

Probably not the nicest fix, but makes zsh autocompletion work.

Unfortunately there's no single styleguide for cli apps to follow, but docker, systemctl and kubectl declare available option values in parentheses.

@bufdev
Copy link
Member

bufdev commented Jul 12, 2020

Can you file an issue to fix cobra instead? There's actually a bunch more places this needs to be changed, and is a bit more involved, as most of these are auto-created (we'd have to change from [ to ( in all of them to be consistent). We can do it depending on Cobra's response, but I would prefer to print out [.

@bufdev
Copy link
Member

bufdev commented Jul 13, 2020

This should be fixed in Cobra instead, or if the fix is already present and we are misusing Cobra, we should fix that. See spf13/cobra#1129

@bufdev bufdev closed this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zsh/Fish completion failing
2 participants