-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .NET 9's JsonStringEnumMemberNameAttribute #833
Conversation
…e handling for CRD generation.
Remove EnumMember. STJ doesn't actually use this. Add a unit test. Test in .NET 9. Unsure if author wants to test both 8 and 9.
Hey @wasabii Thanks for contributing! To correctly check the preview stuff, you will need to annotate all functions that use preview functions with the required attribute (can be seen in the conversion webhook). As such, people that use the SDK need to actively opt in into these features. The reason is that they might change. So, currently the linter is not so happy ;) |
Okay. I couldn't figure out what was going on. I could not build the main branch on a fresh checkout. So I kinda assumed you were doing something by hand.... |
In fact...... I didn't enable the preview features in this branch. If you go over the changes, I haven't done anything to the preview stuff. So this is how it builds main out of the box today.... |
There seems to be an issue with the build of .net 9 |
Adds support for deriving the proper possible values for enum members J decorated with JsonStringEnumMemberNameAttribute. Specifically, I need this to support lowercase values in the CRDs, but PascalCase in .NET.