Remove Wait for windows handle on Restart

budcribar · Feb 24, 2024 · f9a2722 · f9a2722
1 parent aa18e38
commit f9a2722
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 19 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -2,6 +2,6 @@
 <Project>
   <PropertyGroup>
     <PackageOutputPath>$(MSBuildThisFileDirectory)artifacts</PackageOutputPath>
-    <VersionPrefix>8.0.2</VersionPrefix>
+    <VersionPrefix>8.0.3</VersionPrefix>
   </PropertyGroup>
 </Project>
diff --git a/src/RemoteWebView/RemoteWebView.cs b/src/RemoteWebView/RemoteWebView.cs
@@ -63,20 +63,6 @@ public static void Restart(IBlazorWebView blazorWebView)
                 StartInfo = psi
             };
             p.Start();
-
-            int i = 0;
-            // Try to prevent COMException 0x8007139F
-            while (p.MainWindowHandle == IntPtr.Zero)
-            {
-                // Refresh process property values
-                p.Refresh();
-
-                // Wait a bit before checking again
-                Thread.Sleep(100);
-                i++;
-                if (i >= 100)
-                    break;
-            }
         }
 
         private ILogger Logger { get; set; }
@@ -147,7 +133,7 @@ public static void Restart(IBlazorWebView blazorWebView)
         protected WebViewIPC.WebViewIPCClient? Client()
         {
             if (BlazorWebView.ServerUri == null) return null;
-
+            if (BlazorWebView.GrpcBaseUri == null) return null;
             PingIntervalSeconds = BlazorWebView.PingIntervalSeconds;
 
             if (client == null)

diff --git a/testassets/NUnitTestProject/TestRemoteBlazorWpf.cs b/testassets/NUnitTestProject/TestRemoteBlazorWpf.cs
@@ -29,7 +29,7 @@ public class TestRemoteBlazorWpf
         protected static string[] ids = Array.Empty<string>();
         protected static Process? process;
         protected static List<Process> clients = new();
-        protected static int NUM_LOOPS_WAITING_FOR_PAGE_LOAD = 100;
+        protected static int NUM_LOOPS_WAITING_FOR_PAGE_LOAD = 200;
 
         public virtual Process CreateClient()
         {

diff --git a/testassets/NUnitTestProject/TestRemoteEmbeddedBlazorWebView.cs b/testassets/NUnitTestProject/TestRemoteEmbeddedBlazorWebView.cs
@@ -3,7 +3,6 @@
 
 namespace WebdriverTestProject
 {
-    [Ignore]
     [TestClass]
     public class TestRemoteEmbeddedBlazorWebView : TestRemoteBlazorWpf
     {

diff --git a/testassets/NUnitTestProject/WebdriverTestProject.csproj b/testassets/NUnitTestProject/WebdriverTestProject.csproj
@@ -32,7 +32,6 @@
 
 	</ItemGroup>
   <ItemGroup>
-    <Compile Remove="TestRemoteEmbeddedBlazorWebView.cs" />
     <Compile Remove="TestRemotePackageBlazorForm.cs" />
   </ItemGroup>