Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some SVG elements are not visible on resulting image #357

Closed
AndrewN93 opened this issue Jan 5, 2023 · 4 comments · Fixed by #358
Closed

Some SVG elements are not visible on resulting image #357

AndrewN93 opened this issue Jan 5, 2023 · 4 comments · Fixed by #358
Labels
bug released

Comments

@AndrewN93
Copy link
Contributor

AndrewN93 commented Jan 5, 2023 •
edited
Loading

Some elements from the chart missing

There is a bug on attempt to convert chart (Highchartsin my case) into image. I have a chart with circles on it, and if I try to generate image last circles on the chart are missing. This happens when width of the chart is >1000px.
Highcharts supports other shapes such as triangle and they are all displayed on result image, so the problem is only for circle shape.

Expected Behavior

All elements should be on the image

Current Behavior

Circles at very end of the chart are absent on image.

Steps To Reproduce

  1. Visit reproducable demo here
  2. Click on download button
  3. Check the image

Notice: There are 10 circles on the chart on the page, but only 7 circles on the image.

Your Environment

  • html-to-image: 10.3.2
@AndrewN93 AndrewN93 added the bug label Jan 5, 2023
@biiibooo
Copy link
Contributor

biiibooo bot commented Jan 5, 2023

👋 @AndrewN93

Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

AndrewN93 added a commit to AndrewN93/html-to-image that referenced this issue Jan 5, 2023
@AndrewN93
fix(cloneCSSStyle): rounded values of d attr fix
6bac4a4 
There is a difference between values in actual d attribute of path
and value that returns from window.getComputedStyles() object
For some generated svg shapes at particular place is crutial to have
exact values in order them to be displayed at all.

Closes bubkoo#357
@AndrewN93 AndrewN93 mentioned this issue Jan 5, 2023
Merged
15 tasks
@biiibooo biiibooo bot mentioned this issue Jan 9, 2023
Open
@Jaylyn-Barbee
Copy link

Jaylyn-Barbee commented Jan 11, 2023 •
edited
Loading

Tracking! My problem is that it doesn't properly get the background image of my div, so it shows everything but the background image (image is a png). However, my issue is specific to Safari.

bubkoo pushed a commit that referenced this issue Jan 30, 2023
@AndrewN93
fix(cloneCSSStyle): rounded values of d attr fix (#358)
6d28bdb 
There is a difference between values in actual d attribute of path
and value that returns from window.getComputedStyles() object
For some generated svg shapes at particular place is crutial to have
exact values in order them to be displayed at all.

Closes #357
github-actions bot pushed a commit that referenced this issue Jan 30, 2023
chore(release): v1.11.5 [skip ci]
6dfc846 
## [1.11.5](v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([#358](#358)) ([6d28bdb](6d28bdb)), closes [#357](#357)
* include source in npm package ([#316](#316)) ([b609415](b609415))
* switch lazy loading images to eager ([#359](#359)) ([f7c311b](f7c311b))
@biiibooo
Copy link
Contributor

biiibooo bot commented Jan 30, 2023

🎉 This issue has been resolved in version 1.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@biiibooo biiibooo bot added the released label Jan 30, 2023
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
@AndrewN93 @istaiti
fix(cloneCSSStyle): rounded values of d attr fix (bubkoo#358)
2bbd05b 
There is a difference between values in actual d attribute of path
and value that returns from window.getComputedStyles() object
For some generated svg shapes at particular place is crutial to have
exact values in order them to be displayed at all.

Closes bubkoo#357
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
@istaiti
chore(release): v1.11.5 [skip ci]
69340f2 
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357)
* include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415))
* switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
@AndrewN93 @istaiti
fix(cloneCSSStyle): rounded values of d attr fix (bubkoo#358)
002b281 
There is a difference between values in actual d attribute of path
and value that returns from window.getComputedStyles() object
For some generated svg shapes at particular place is crutial to have
exact values in order them to be displayed at all.

Closes bubkoo#357
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
@istaiti
chore(release): v1.11.5 [skip ci]
b23710b 
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357)
* include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415))
* switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
@AndrewN93 @istaiti
fix(cloneCSSStyle): rounded values of d attr fix (bubkoo#358)
8a5c38a 
There is a difference between values in actual d attribute of path
and value that returns from window.getComputedStyles() object
For some generated svg shapes at particular place is crutial to have
exact values in order them to be displayed at all.

Closes bubkoo#357
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
@istaiti
chore(release): v1.11.5 [skip ci]
c8558a6 
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357)
* include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415))
* switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
@AndrewN93 @istaiti
fix(cloneCSSStyle): rounded values of d attr fix (bubkoo#358)
1837edf 
There is a difference between values in actual d attribute of path
and value that returns from window.getComputedStyles() object
For some generated svg shapes at particular place is crutial to have
exact values in order them to be displayed at all.

Closes bubkoo#357
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
@istaiti
chore(release): v1.11.5 [skip ci]
10107ea 
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357)
* include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415))
* switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
@AndrewN93 @istaiti
fix(cloneCSSStyle): rounded values of d attr fix (bubkoo#358)
798a208 
There is a difference between values in actual d attribute of path
and value that returns from window.getComputedStyles() object
For some generated svg shapes at particular place is crutial to have
exact values in order them to be displayed at all.

Closes bubkoo#357
istaiti pushed a commit to inscreen/html-to-image that referenced this issue Feb 7, 2023
@istaiti
chore(release): v1.11.5 [skip ci]
40cccc1 
## [1.11.5](bubkoo/html-to-image@v1.11.4...v1.11.5) (2023-01-30)

### Bug Fixes

* **cloneCSSStyle:** rounded values of d attr fix ([bubkoo#358](bubkoo#358)) ([6d28bdb](bubkoo@6d28bdb)), closes [bubkoo#357](bubkoo#357)
* include source in npm package ([bubkoo#316](bubkoo#316)) ([b609415](bubkoo@b609415))
* switch lazy loading images to eager ([bubkoo#359](bubkoo#359)) ([f7c311b](bubkoo@f7c311b))
@biiibooo
Copy link
Contributor

biiibooo bot commented Jan 31, 2024

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@biiibooo biiibooo bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cloneCSSStyle): rounded values of d attribute fix AndrewN93/html-to-image
2 participants
@AndrewN93 @Jaylyn-Barbee