Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txscript: Refactor to implement tokenizer from drcd #1685

Closed
wants to merge 1 commit into from

Conversation

kcalvinalvin
Copy link
Collaborator

parseScriptTemplate will allocate a copy of the script onto memory,
leading to excessive memory allocation. This commit brings the tokenizer
to btcd and modifies it to fit with Bitcoin.

parseScriptTemplate will allocate a copy of the script onto memory,
leading to excessive memory allocation. This commit brings the tokenizer
to btcd and modifies it to fit with Bitcoin.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 530188701

  • 853 of 1025 (83.22%) changed or added relevant lines in 9 files are covered.
  • 19 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.03%) to 53.426%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mempool/policy.go 0 1 0.0%
txscript/tokenizer.go 72 76 94.74%
txscript/sign.go 22 28 78.57%
txscript/script.go 199 224 88.84%
txscript/engine.go 212 248 85.48%
txscript/standard.go 207 307 67.43%
Files with Coverage Reduction New Missed Lines %
txscript/engine.go 1 88.12%
txscript/sign.go 1 74.44%
txscript/pkscript.go 3 80.62%
txscript/script.go 7 89.34%
txscript/standard.go 7 76.66%
Totals Coverage Status
Change from base Build 512434868: 0.03%
Covered Lines: 20949
Relevant Lines: 39211

💛 - Coveralls

@onyb
Copy link
Contributor

onyb commented Apr 12, 2021

Propose to close this in favour of #1684.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants