Alternative implementation of JWT lib #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function __construct(JwtBearerInterface $storage, $audience, EncryptionInterface $jwtUtil = null) | ||
| public function __construct(JwtBearerInterface $storage, $audience, EncryptionInterface $jwtUtil = null, $allowedAlgorithms = null) |
There was a problem hiding this comment.
This is great!! I think the only thing I would change is make the constructor the following for consistency:
public function __construct(JwtBearerInterface $storage, $audience, EncryptionInterface $jwtUtil = null, $config = array())
{
// ...
$this->config = array_merge(array(
'allowed_algorithms' => array('RS256', 'RS384', 'RS512')
));
// ...
}This just keeps it consistent with the rest of the library
There was a problem hiding this comment.
Ah yep, nice catch. Have submitted an updated commit now.
An alternate patch that maintains backwards compatibility with existing interfaces, but is unsafe for users who call JWT::decode themselves without passing the allowed arguments array.
6c496b9 to
535d658
Compare
|
I've updated the constructor, so this should be all good to go now 👍 |
|
woohoo! Looks great! |
bshaffer
added a commit
that referenced
this pull request
Apr 23, 2015
Alternative implementation of JWT lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternate patch to PR #567 that maintains backwards compatibility with existing interfaces, but is unsafe for users who call
JWT::decodethemselves without passing the allowed arguments array.The allowed algorithms for the
JWTBearergrant type are specified as an additional argument to the constructor, with defaults set if the argument is null.Addresses #564.