Fix #505 dynamodb value must not be empty #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
two thoughts on this PR... and sorry it has taken me so long to review it...
Thank you! |
…b storage. Adding test for dynamodb storage. Default scope should be null when none is set in the database. Removing immediate return true in dynamodb test.
bca40bc to
0786a36
Compare
|
not a problem. thanks for looking into it.
|
bshaffer
added a commit
that referenced
this pull request
Mar 24, 2015
…be-empty Fix #505 dynamodb value must not be empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed filtering of client data by using empty() instead of is_null() in the setAccessToken, setAuthorizationCode and setRefreshToken methods of the DynamoDB storage..
Changed the getDefaultScope method to return null if there is no default scope set in the database.
Added tests for these changes.