Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bowl and flywheel examples #106

Closed
wants to merge 3 commits into from
Closed

bowl and flywheel examples #106

wants to merge 3 commits into from

Conversation

zignig
Copy link

@zignig zignig commented Jul 24, 2023

Two more examples, general exploration.

@bschwind
Copy link
Owner

Nice! I'll try these out. Do note that the modeling API is subject to change, especially for boolean subtraction (see #107 for an example) and workplane manipulation. If this gets merged first I'll be happy to update them to whatever is most idiomatic at the time, though.

@bschwind
Copy link
Owner

Also it's not at all obvious, but I don't intend for many people to create models with this crate directly, the compilation times are terrible.

I want to make a lightweight modeling API that compiles to WASM, which gets loaded by a viewer binary and executed. So you'll get live-updating renders as you code, compilation times are fast, and everyone is happy.

The modeling API will likely look very similar or identical to what I have now though, depending on how the WASM stuff goes.

@bschwind
Copy link
Owner

Ooh, cool flywheel!

Screen Shot 2023-07-24 at 10 48 28 PM

@bschwind
Copy link
Owner

By the way, I'm going to run the CI workflows but it'll probably ding you for formatting.

You can run cargo +nightly fmt to fix it.

I wish rustfmt had this option (there's an open PR), but I prefer trailing zeroes on float literals (0. -> 0.0). Sorry for being pedantic, it should already be in rustfmt to be honest.

@bschwind
Copy link
Owner

bschwind commented Aug 5, 2023

@zignig I'm not sure I have permission to push to your fork's branch. I rebased your branch on the latest main, you can see the changes I made here:

https://github.com/bschwind/opencascade-rs/compare/bowl-flywheel-rebase?expand=1

This particular commit

@zignig
Copy link
Author

zignig commented Aug 13, 2023

With some changes with the api, I'll rewrite them anyway. Close this pull and I will make a new one.

@zignig zignig closed this Aug 13, 2023
@bschwind
Copy link
Owner

bschwind commented Nov 4, 2023

@zignig it's been awhile since I've put focused work into this project, but I'll happily add your examples to the main repo if you'd like to update them to the current modeling API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants