Skip to content

Commit

Permalink
Merge pull request #378 from bruin-data/fix-lint-2
Browse files Browse the repository at this point in the history
Update Makefile to specify golangci-lint version
  • Loading branch information
karakanb authored Jan 3, 2025
2 parents 476c32b + a6b7bf7 commit b8b91a5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ tools:

@if ! command -v golangci-lint > /dev/null ; then \
echo ">> [$@]: golangci-lint not found: installing"; \
go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest; \
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.63.2; \
fi

tools-update:
Expand Down
6 changes: 3 additions & 3 deletions pkg/pipeline/pipeline.go
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ func (m Materialization) MarshalJSON() ([]byte, error) {
})
}

type ColumnCheckValue struct { //nolint: recvcheck
type ColumnCheckValue struct {
IntArray *[]int `json:"int_array"`
Int *int `json:"int"`
Float *float64 `json:"float"`
Expand Down Expand Up @@ -860,7 +860,7 @@ func uniqueAssets(assets []*Asset) []*Asset {
return unique
}

type EmptyStringMap map[string]string //nolint: recvcheck
type EmptyStringMap map[string]string

func (m EmptyStringMap) MarshalJSON() ([]byte, error) { //nolint: stylecheck
if m == nil {
Expand Down Expand Up @@ -888,7 +888,7 @@ func (b *EmptyStringMap) UnmarshalJSON(data []byte) error {
return nil
}

type EmptyStringArray []string //nolint: recvcheck
type EmptyStringArray []string

func (a EmptyStringArray) MarshalJSON() ([]byte, error) {
if a == nil {
Expand Down

0 comments on commit b8b91a5

Please sign in to comment.