Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cases #2495

Merged
merged 13 commits into from
Jan 21, 2025
Merged

Cases #2495

merged 13 commits into from
Jan 21, 2025

Conversation

brucemiller
Copy link
Owner

This PR makes \MakeUppercase,\MakeLowercase more consistent with current LaTeX implementation, particularly as to using Unicode mappings rather than \uccode,\lccode. The mechanisms used for defining mappings and exclusion rely on control sequences being robust (being protected and redirecting through a cs with space appended), so a number of commands have been updated.
In the process a couple of other patches: Definition's alias is now consistently a Token, rather than string; reduced unnecessary debugging noise, warnings, etc.

@brucemiller brucemiller requested a review from dginev January 20, 2025 16:24
Copy link
Collaborator

@dginev dginev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive changeset. I read through the full PR, left some minor comments.

lib/LaTeXML/Core/Definition.pm Show resolved Hide resolved
lib/LaTeXML/Core/Document.pm Outdated Show resolved Hide resolved
lib/LaTeXML/Core/Document.pm Show resolved Hide resolved
lib/LaTeXML/Engine/LaTeX.pool.ltxml Show resolved Hide resolved
lib/LaTeXML/Engine/plain.pool.ltxml Show resolved Hide resolved
lib/LaTeXML/Package.pm Outdated Show resolved Hide resolved
lib/LaTeXML/Package.pm Outdated Show resolved Hide resolved
@brucemiller brucemiller merged commit 14358d3 into master Jan 21, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants