Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated package to use angular 16. #172

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

JanneHarju
Copy link
Contributor

Node types was also needed to update to 18 because 17 is not supported by angulat 16 and also there was some error when running build command.
Readme updated.
When updating I used ng update command.

…te to 18 because 17 is not supported by angulat 16 and also there was some error when running build command. Readme updated.
@Coffee-Tea
Copy link
Collaborator

Were u able to check is updated version working for your angular v16 app?

@JanneHarju
Copy link
Contributor Author

Not yet. I could publish package to our private server or just make pack and install it in our project. First thing tomorrow I will do is that.

@Coffee-Tea
Copy link
Collaborator

You can build it locally and link it to your project. Google for how to npm link

@JanneHarju
Copy link
Contributor Author

There is still same problem. I will try to figure it out why this is not Ivy NgModule.

@JanneHarju
Copy link
Contributor Author

Forget about last message. There was some extra useless node_modules folder in library folder with old version of this package. So 15 versio also works with my Angular 16 app. There is just some version miss match warnings if it is used. So this should work. I will update package number which I forget to do.

@Coffee-Tea
Copy link
Collaborator

@JanneHarju so what is resolution regarding this:

  1. Is v15 lib working for v16 app?
  2. Will v16 lib be working for v16 app if we merge it release? (have you tested)

@JanneHarju
Copy link
Contributor Author

  1. Yes it works with 15 and 16 after I removed that my extra node_modules folder what my library was using.
  2. Yes it works. At least in our usage.

@JanneHarju
Copy link
Contributor Author

Can someone merge this? @brtnshrdr can you do it?

@Coffee-Tea
Copy link
Collaborator

@JanneHarju I will try to find time to release it today, Soryr for delay

@Coffee-Tea Coffee-Tea merged commit 08d8580 into brtnshrdr:master Aug 24, 2023
@JanneHarju JanneHarju deleted the feature/angular16support branch August 24, 2023 07:09
@Coffee-Tea
Copy link
Collaborator

@JanneHarju I have just published v16 to npm
could u please check it out and let me know does it work for your project?

https://www.npmjs.com/package/angular2-hotkeys/v/16.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants