Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update puppeteer version #112

Closed
Manvel opened this issue Apr 22, 2023 · 0 comments
Closed

Update puppeteer version #112

Manvel opened this issue Apr 22, 2023 · 0 comments

Comments

@Manvel
Copy link
Member

Manvel commented Apr 22, 2023

Background

In order to update the PPTR version we need to do some adjustments:

//main.js
const backgroundPageTarget = targets.find((target) =>
          target.url().startsWith("chrome-extension://") && target.type() === "background_page"
        );

Also: setListeners in tests/tests/utils.js seem to fail after update, as _pageBindings is no more seem to be available in PPTR latest version and we need to find a way to reset exposed function.

Manvel added a commit that referenced this issue Apr 30, 2023
There seem to be no easy way to remove already exposed function in
latest puppeteer, so we instead assign UID to the method name, rather
doing cleanup.
Manvel added a commit that referenced this issue Apr 30, 2023
There seem to be no easy way to remove already exposed function in
latest puppeteer, so we instead assign UID to the method name, rather
doing cleanup.
Manvel added a commit that referenced this issue May 6, 2023
Manvel added a commit that referenced this issue May 6, 2023
* updated puppeteer version and fixed BG page retrieval
* _pageBindings is not available in pptr 19

There seem to be no easy way to remove already exposed function in
latest puppeteer, so we instead assign UID to the method name, rather
doing cleanup.

* increase wait time to fix flaky tests
* update puppeteer version to 20.1.1
@Manvel Manvel closed this as completed Dec 25, 2023
Manvel added a commit that referenced this issue Dec 29, 2023
* Issue #122 - introduced RPC connection and types

* Issue #122 - Introduced getState from the BG

* Issue #112 - use getCbaState method for checking the state

* Issue 122 - cleanup

* Issue #122 - move lastSelectedProjectId and lastSelectedActionId to prefs

* Issue #122 - use RPC for RecordProject and StopProject
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant