Addressing instance methods in external annotations #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
This PR expands the capabilities of the resolution code used for external markers and the
--analyze
command line argument to handle more complex Rust paths, such as<Type as Trait>::method
.We reuse rustcs own parser to interpret the user-supplied string as a "path".
Why Does It Need To?
Currently external markers and the
--analyze
command line argument are limited to simple paths (e.g.std::vec::Vec
) and cannot target methods of a trait impl. This PR removes that limitation.Checklist
otype
annotation.good record of what changed.
if necessary
.github/workflows/rust.yml
) either as compiler test or integration test.Or justification for their omission from CI has been provided in this PR
description.