Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme for the vim editor #936

Open
Donkeyfish87 opened this issue Mar 14, 2019 · 8 comments
Open

Theme for the vim editor #936

Donkeyfish87 opened this issue Mar 14, 2019 · 8 comments

Comments

@Donkeyfish87
Copy link

This is not a bug, more of a feature request:

Add the possibility to change the theme of the vim editor that shows up on ctrl+i.

@rcrx
Copy link

rcrx commented Mar 31, 2019

What is going on with the settings?

I've modified settings.theme and yet it results in no change to the theme.

@surfcao
Copy link

surfcao commented Apr 24, 2019

Related to this, I would like to see the options to change the default font in ACE editor.

@chaorace
Copy link

chaorace commented May 22, 2019

This is already possible with some creative use of settings.theme. Here's an example of my themed editor (some other stuff like transparency is added as well):

settings.theme= `
:root {
    --theme-ace-bg:#282828ab; /*Note the fourth channel, this adds transparency*/
    --theme-ace-bg-accent:#3c3836;
    --theme-ace-fg:#ebdbb2;
    --theme-ace-fg-accent:#7c6f64;
    --theme-ace-cursor:#928374;
    --theme-ace-select:#458588;
}
#sk_editor {
    height: 50% !important; /*Remove this to restore the default editor size*/
    background: var(--theme-ace-bg) !important;
}
.ace-chrome .ace_print-margin, .ace_gutter, .ace_gutter-cell, .ace_dialog{
    background: var(--theme-ace-bg-accent) !important;
}
.ace_dialog-bottom{
    border-top: 1px solid var(--theme-ace-bg) !important;
}
.ace-chrome{
    color: var(--theme-ace-fg) !important;
}
.ace_gutter, .ace_dialog {
    color: var(--theme-ace-fg-accent) !important;
}
.ace_cursor{
    color: var(--theme-ace-cursor) !important;
}
.normal-mode .ace_cursor{
    background-color: var(--theme-ace-cursor) !important;
    border: var(--theme-ace-cursor) !important;
}
.ace_marker-layer .ace_selection {
    background: var(--theme-ace-select) !important;
} `

@Monirzadeh
Copy link

Monirzadeh commented Jun 1, 2019

thanks i add your sample into wiki

@chaorace
Copy link

chaorace commented Jun 2, 2019

I appreciate being added to the wiki, but that example was really rough and I'm a bit embarrassed by it. I've gone ahead and updated the example to serve as a better template to work off of and removed some extraneous general theme adjustments.

@chaorace
Copy link

chaorace commented Jun 2, 2019

By the way @surfcao :
You can set the default font using a rule like this in your settings.theme. Keep in mind that your browser has to have the font actually installed for it to work.

.ace_editor {
    font: 12px/normal 'Consolas', monospace !important;
}

@surfcao
Copy link

surfcao commented Jul 8, 2019

By the way @surfcao :
You can set the default font using a rule like this in your settings.theme. Keep in mind that your browser has to have the font actually installed for it to work.

.ace_editor {
font: 12px/normal 'Consolas', monospace !important;
}

Thanks for the answer and sorry for the late response. Yes, this will change the fonts and looks in the editor, however, after the editing and writing to the text/input area, the original font in the input area (e.g., gmail compose window) will not be kept.

kawamataryo added a commit to kawamataryo/Surfingkeys that referenced this issue Sep 18, 2022
kawamataryo added a commit to kawamataryo/Surfingkeys that referenced this issue Sep 18, 2022
@kawamataryo
Copy link

I had the same problem and created a PR.
#1839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants