Initialize processor in build
, prevent reusing same strategy
#218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in
broccoli-persistent-filter
, it's not really possible to use your own state on your subclass of it in the overall bucketcacheKey
for a few reasons:super
call, then immediately stashes a memoized cache key on the constructor; this makes it difficult to instrumentcacheKey
with state that you have on your subclass without workarounds.broccoli-persistent-filter
to clobber properties (namely the caches) on the persistent strategy object.This PR resolves both of these issues. We now only initialize the processor in
build
, but we guard it to only do this once; we also shallow clone the strategy object, so we don't unnecessarily reuse it across instances ofbroccoli-persistent-filter
.