Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDestFilePath: handle non-existent (deleted/moved) files #207

Merged
merged 2 commits into from
Oct 22, 2020
Merged

getDestFilePath: handle non-existent (deleted/moved) files #207

merged 2 commits into from
Oct 22, 2020

Conversation

jamescdavis
Copy link
Contributor

@jamescdavis jamescdavis commented Oct 22, 2020 •
edited
Loading

broccoli-persistent-filter/src/index.ts

Lines 422 to 424 in 87738eb

getDestFilePath(relativePath: string, entry: Entry) {
// NOTE: relativePath may have been moved or unlinked
if (this.isDirectory(relativePath, entry)) {

see failing test and fix commits

@jamescdavis jamescdavis force-pushed the handle_deleted_file_getDestFilePath branch 2 times, most recently from f931d1a to 0f74d07 Compare October 22, 2020 04:08
@jamescdavis jamescdavis mentioned this pull request Oct 22, 2020
Closed
rwjblue
rwjblue requested changes Oct 22, 2020
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
@jamescdavis jamescdavis force-pushed the handle_deleted_file_getDestFilePath branch from 0f74d07 to 70f7fd2 Compare October 22, 2020 13:26
@jamescdavis jamescdavis force-pushed the handle_deleted_file_getDestFilePath branch from 70f7fd2 to 7bbaf88 Compare October 22, 2020 13:32
rwjblue
rwjblue approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jamescdavis!

@jamescdavis jamescdavis changed the title getDestFilePath: handle non-existent files (deleted/moved) files getDestFilePath: handle non-existent (deleted/moved) files Oct 22, 2020
@rwjblue rwjblue merged commit 19f2626 into broccolijs:master Oct 22, 2020
@rwjblue rwjblue added the bug label Oct 22, 2020
@rwjblue
Copy link
Member

rwjblue commented Oct 22, 2020

https://github.com/broccolijs/broccoli-persistent-filter/releases/tag/v3.1.2

@jamescdavis jamescdavis deleted the handle_deleted_file_getDestFilePath branch October 22, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamescdavis @rwjblue