Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary calculation #9077

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Remove unnecessary calculation #9077

merged 1 commit into from
Jan 16, 2025

Conversation

lbergelson
Copy link
Member

  • remove the field FlowBaseRead.forwardSequence which was calculated at non-trivial cost and then only used for it's length
  • removed the method seqLength because it was a more convoluted version of getLength
  • fixed some typos and finals because I couldn't help myself

@lbergelson
Remove unecessary calculation and methods in FlowBasedRead
cbce63f 
* remove the field FlowBaseRead.forwardSequence was calculated at non-trivial cost and then only used for it's length
* removed the method seqlength because it was a more convoluted of getLength
* fixed some typos and finals because I couldn't help myself
@jamesemery
Copy link
Collaborator

This looks fine to me on the surface...

@lbergelson
Copy link
Member Author

@jamesemery Are you ok with merging this?

@lbergelson lbergelson merged commit 717d8a9 into master Jan 16, 2025
20 checks passed
@lbergelson lbergelson deleted the lb_remove_unecessary_calculation branch January 16, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesemery jamesemery jamesemery approved these changes

Assignees

@jamesemery jamesemery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbergelson @jamesemery