Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert that ELBO did not become NaN during each step of inference #6186

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Assert that ELBO did not become NaN during each step of inference #6186

merged 1 commit into from
Oct 28, 2019

Conversation

asmirnov239
Copy link
Collaborator

gCNV does not fail if the ELBO becomes NaN and just finishes the maximum number of allowed iterations. This check would save some time and lead to less cryptic errors downstream

@asmirnov239
Copy link
Collaborator Author

@mwalker174 Could you review this as well?

mwalker174
mwalker174 approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks fine. It would be good to have a more helpful message but maybe we should first confirm what the problem is.

@samuelklee
Copy link
Contributor

@asmirnov239 should we merge this?

@asmirnov239 asmirnov239 merged commit 22eb06c into master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwalker174 mwalker174 mwalker174 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asmirnov239 @samuelklee @mwalker174