Added docker to the gcnv QC tasks #6185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwalker174 Could you please review? |
mwalker174
approved these changes
Sep 26, 2019
scripts/cnv_wdl/cnv_common_tasks.wdl
Outdated
| @@ -484,6 +485,7 @@ task CollectSampleQualityMetrics { | |||
| >>> | |||
|
|
|||
| runtime { | |||
| docker: "${gatk_docker}" | |||
There was a problem hiding this comment.
Change to:
docker: gatk_docker
This will make the upgrade to WDL 1.0 just a bit easier.
There was a problem hiding this comment.
Replaced here and in all occurrences of gCNV WDLs
scripts/cnv_wdl/cnv_common_tasks.wdl
Outdated
| @@ -532,6 +535,7 @@ task CollectModelQualityMetrics { | |||
| >>> | |||
|
|
|||
| runtime { | |||
| docker: "${gatk_docker}" | |||
|
@asmirnov239 can you address comments and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terra does not allow running a container without docker specified so here is a fix