Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waived an unnecessary IllegalArgumentException in PairHMM #5705

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

davidbenjamin
Copy link
Contributor

Closes #5543.

@kachulis Could you review this PR?

@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #5705 into master will increase coverage by 0.002%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #5705       +/-   ##
===============================================
+ Coverage     87.066%   87.068%   +0.002%     
- Complexity     31853     31854        +1     
===============================================
  Files           1940      1940               
  Lines         146679    146678        -1     
  Branches       16218     16218               
===============================================
+ Hits          127707    127709        +2     
+ Misses         13060     13059        -1     
+ Partials        5912      5910        -2
Impacted Files Coverage Δ Complexity Δ
...oadinstitute/hellbender/utils/pairhmm/PairHMM.java 78.417% <ø> (+0.56%) 24 <0> (ø) ⬇️
...nder/utils/runtime/StreamingProcessController.java 68.246% <0%> (+0.948%) 34% <0%> (+1%) ⬆️

@lbergelson
Copy link
Member

Ah, @TedBrookings it looks like your initial thought was right and I was too cautious :)

Copy link
Contributor

@kachulis kachulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@davidbenjamin davidbenjamin merged commit 0d5fcbf into master Feb 22, 2019
@davidbenjamin davidbenjamin deleted the db_waive branch February 22, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants