Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the same flags for all JavaCompile gradle tasks #5256

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

lbergelson
Copy link
Member

  • simplifying a few line in build.gradle and making all JavaCompile tasks apply the same compiler arguments
  • previously this didn't apply to compileJavaTestUtils

* simplifying a few line in build.gradle and making all JavaCompile tasks apply the same compiler arguments
* previously this didn't apply to compileJavaTestUtils
@codecov-io
Copy link

Codecov Report

Merging #5256 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##              master     #5256   +/-   ##
===========================================
  Coverage     86.757%   86.757%           
  Complexity     29832     29832           
===========================================
  Files           1828      1828           
  Lines         138115    138115           
  Branches       15227     15227           
===========================================
  Hits          119824    119824           
  Misses         12744     12744           
  Partials        5547      5547

Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@lbergelson lbergelson merged commit 868a32e into master Oct 4, 2018
@lbergelson lbergelson deleted the lb_disallow_warnings_in_testUtils branch October 4, 2018 14:13
EdwardDixon pushed a commit to EdwardDixon/gatk that referenced this pull request Nov 9, 2018
)

* simplifying a few line in build.gradle and making all JavaCompile tasks apply the same compiler arguments
* previously this didn't apply to compileJavaTestUtils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants