Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup - squid:S2974 - Classes without public constructors should be… #1968

Merged
merged 1 commit into from
Jul 1, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ protected String getSummaryLineForLevel(final int indentLevel) {
/**
* Private class for Counting AND filters
*/
private class CountingAndReadFilter extends CountingBinopReadFilter {
private final class CountingAndReadFilter extends CountingBinopReadFilter {

private static final long serialVersionUID = 1L;

Expand All @@ -167,7 +167,7 @@ public boolean test(final GATKRead read) {
/**
* Private class for Counting OR filters
*/
private class CountingOrReadFilter extends CountingBinopReadFilter {
private final class CountingOrReadFilter extends CountingBinopReadFilter {

private static final long serialVersionUID = 1L;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public final class MeanQualityByCycle extends SinglePassSamProgram {

private final Logger logger = LogManager.getLogger(this.getClass());

private static class HistogramGenerator {
private static final class HistogramGenerator {
final boolean useOriginalQualities;
int maxLengthSoFar = 0;
double[] firstReadTotalsByCycle = new double[maxLengthSoFar];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ protected String[] customCommandLineValidation() {
* Allows for lazy construction of the second-of-pair writer, since when we are in the "output per read group mode", we only wish to
* generate a second-of-pair fastq if we encounter a second-of-pair read.
*/
static class FastqWriters {
static final class FastqWriters {
private final FastqWriter firstOfPair, unpaired;
private final Lazy<FastqWriter> secondOfPair;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ protected VariantCallContext calculateGenotypes(final FeatureContext features,
* Holds information about the alternative allele subsetting based on supporting evidence, genotyping and
* output modes.
*/
private static class OutputAlleleSubset {
private static final class OutputAlleleSubset {
private final Allele[] alleles;
private final boolean siteIsMonomorphic;
private final int[] mleCounts;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1157,7 +1157,7 @@ private static CigarPairTransform getTransformer(final CigarOperator op12, final
* so not present in 3). We advance the cigar in 1 by 1 (as we've consumed one base in 1 for the I)
* but we haven't yet found the base corresponding to the M of op23. So we don't advance23.
*/
private static class CigarPairTransform {
private static final class CigarPairTransform {
private final EnumSet<CigarOperator> op12, op23;
private final CigarOperator op13;
private final int advance12, advance23;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ public void close() {
};
}

private class SuffixTrimingSamRecordIterator implements CloseableIterator<SAMRecord> {
private final class SuffixTrimingSamRecordIterator implements CloseableIterator<SAMRecord> {
private final CloseableIterator<SAMRecord> underlyingIterator;
private final String suffixToTrim;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/**
* Class with helper methods to convert objects (mostly matrices) to/from Spark (particularly, in MLLib)
*/
public class SparkConverter {
public final class SparkConverter {
private static final Logger logger = LogManager.getLogger(SparkConverter.class);

private SparkConverter() {
Expand Down