Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[AN-146] Emit VM cost for GCP Batch" #7669

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Revert "[AN-146] Emit VM cost for GCP Batch" #7669

merged 3 commits into from
Dec 10, 2024

Conversation

lucymcnatt
Copy link
Contributor

@lucymcnatt lucymcnatt commented Dec 9, 2024 •
edited
Loading

Reverts #7582

Some failures in the GCP batch centaur tests

@aednichols aednichols mentioned this pull request Dec 9, 2024
Merged
4 tasks
@lucymcnatt lucymcnatt marked this pull request as ready for review December 9, 2024 22:58
@lucymcnatt lucymcnatt requested a review from a team as a code owner December 9, 2024 22:58
aednichols
aednichols approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will need to update from develop to pick up both the BigQuery removal and the new DB test case names, which I've asked GitHub to require once more.

Necessary changes, annoying timing; thank you for your patience!

@lucymcnatt lucymcnatt merged commit 860429b into develop Dec 10, 2024
43 checks passed
@lucymcnatt lucymcnatt deleted the revert-7582-AN-146-batch-vm-cost branch December 10, 2024 15:08
lucymcnatt added a commit that referenced this pull request Dec 10, 2024
@lucymcnatt
Revert "Revert "[AN-146] Emit VM cost for GCP Batch" (#7669)"
ac2de89 
This reverts commit 860429b.
@lucymcnatt lucymcnatt mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizBaldo LizBaldo LizBaldo approved these changes

@aednichols aednichols aednichols approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucymcnatt @aednichols @LizBaldo