Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1633 Streamline, enhance debug image #7443

Merged
merged 2 commits into from
May 22, 2024
Merged

WX-1633 Streamline, enhance debug image #7443

merged 2 commits into from
May 22, 2024

Conversation

aednichols
Copy link
Collaborator

@aednichols aednichols commented May 21, 2024

Description

After using it in practice for a while, here's a small round of changes:

  • Remove JDK. This was by far the largest by megabytes and the most fickle build process. It was really only there in case I wanted to use jstack as a backup if I couldn't connect YourKit; but we now have a blessed procedure to run YourKit in any environment.
  • Message-of-the-day on container login. Enhanced situational awareness to make sure you're on the container you want, and the container is running the version you think it is.

Without the JDK, the image is 634 MB, only 16% larger than baseline at 547 MB.

MOTD example:

> kubectl exec -it -n terra-dev cromwell1-runner-76f7b5d5df-qpwdl -c cromwell1-runner-app -- bash
Version 88-6e242af-DEBUG built at 2024-05-21 18:07:36
root@cromwell1-runner-76f7b5d5df-qpwdl:/# 

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@aednichols aednichols requested a review from a team as a code owner May 21, 2024 23:39
s"""apt-get update -qq && \\
|apt-get install -qq --no-install-recommends file gpg htop jq less nload unzip vim && \\
|rm -rf /var/lib/apt/lists/* && \\
|mkdir /tmp/docker-build-cache && \\
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added mkdir is not strictly necessary because wget would create it for us; but makes it clear that we are manually creating this folder for ourselves, rather than being some kind of built-in Docker magic.

@aednichols aednichols enabled auto-merge (squash) May 22, 2024 13:13
@aednichols aednichols merged commit 020fb1a into develop May 22, 2024
36 of 37 checks passed
@aednichols aednichols deleted the aen_wx_1633_2 branch May 22, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants