Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1252 Runtime attributes cleanup – CWL runtime attributes #7370

Merged
merged 8 commits into from
Feb 23, 2024
Merged

WX-1252 Runtime attributes cleanup – CWL runtime attributes #7370

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
db08451
Clean up unused CWL attributes
aednichols Feb 22, 2024
701a2a2
Fix compiling
aednichols Feb 22, 2024
6ce28fd
Scala format
aednichols Feb 22, 2024
a87165b
Fix test compilation
aednichols Feb 22, 2024
79204f2
Fix test compiling
aednichols Feb 22, 2024
2876e42
Fix test
aednichols Feb 22, 2024
982cccf
Fix test
aednichols Feb 22, 2024
b5666c0
Fix test
aednichols Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix compiling
  • Loading branch information
@aednichols
aednichols committed Feb 22, 2024
commit 701a2a20c1999236d88915f34b43c7d38ea15d71
5 changes: 3 additions & 2 deletions backend/src/main/scala/cromwell/backend/RuntimeEnvironment.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package cromwell.backend
import java.util.UUID

import cromwell.backend.io.JobPaths
import cromwell.backend.validation.{CpuValidation, MemoryValidation}
import cromwell.backend.validation.MemoryValidation
import cromwell.core.path.Path
import eu.timepit.refined.api.Refined
import eu.timepit.refined.numeric.Positive
Expand All @@ -27,7 +27,8 @@ object RuntimeEnvironmentBuilder {
callRoot.resolve(s"tmp.$hash").pathAsString
}

val cores: Int Refined Positive = CpuValidation.instanceMin.validate(runtimeAttributes).getOrElse(minimums.cores)
// This class is going away in https://github.com/broadinstitute/cromwell/pull/7369
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and this statement needed updating to keep these PRs compiling while in separate branches (incredibly, the only overlap)

val cores: Int Refined Positive = minimums.cores

val memoryInMB: Double =
MemoryValidation
Expand Down
Loading