Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1351 Speed up Centaur Horicromtal PapiV2 Beta #7329

Merged
merged 9 commits into from
Dec 5, 2023
Merged

WX-1351 Speed up Centaur Horicromtal PapiV2 Beta #7329

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a26ca25
Standalone test
aednichols Dec 4, 2023
213ee02
Improved statistics
aednichols Dec 4, 2023
c420110
Merge branch 'develop' into aen_wx_1351_3
aednichols Dec 4, 2023
0559362
Fix typo
aednichols Dec 4, 2023
3310323
Merge remote-tracking branch 'origin/aen_wx_1351_3' into aen_wx_1351_3
aednichols Dec 4, 2023
1e01f0e
Emphasis
aednichols Dec 4, 2023
07f056c
Merge branch 'develop' into aen_wx_1351_3
aednichols Dec 4, 2023
5836edf
Exclude subworkflows
aednichols Dec 5, 2023
4075432
Merge remote-tracking branch 'origin/aen_wx_1351_3' into aen_wx_1351_3
aednichols Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/main/resources/reference.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ system {
max-concurrent-workflows = 5000

# Cromwell will launch up to N submitted workflows at a time, regardless of how many open workflow slots exist
max-workflow-launch-count = 50
# Deviating from 1 is not recommended for multi-runner setups due to possible deadlocks. [BW-962]
max-workflow-launch-count = 1

# Workflows will be grouped by the value of the specified field in their workflow options.
#
Expand Down
36 changes: 36 additions & 0 deletions src/ci/bin/test.inc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,6 +1607,42 @@ cromwell::build::generate_code_coverage() {
fi
}

cromwell::build::print_workflow_statistics() {
echo "Total workflows"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mysql --host=127.0.0.1 --user=cromwell --password=test cromwell_test -e \
"SELECT COUNT(*) as total_workflows_run FROM WORKFLOW_METADATA_SUMMARY_ENTRY;"

echo "Late starters"
mysql --host=127.0.0.1 --user=cromwell --password=test cromwell_test -e \
"SELECT WORKFlOW_NAME as name,
TIMESTAMPDIFF(MINUTE, START_TIMESTAMP, END_TIMESTAMP) as runtime_minutes,
START_TIMESTAMP as START,
END_TIMESTAMP as end
FROM WORKFLOW_METADATA_SUMMARY_ENTRY
ORDER BY START_TIMESTAMP DESC
LIMIT 20;"

echo "Late finishers"
mysql --host=127.0.0.1 --user=cromwell --password=test cromwell_test -e \
"SELECT WORKFlOW_NAME as name,
TIMESTAMPDIFF(MINUTE, START_TIMESTAMP, END_TIMESTAMP) as runtime_minutes,
START_TIMESTAMP as start,
END_TIMESTAMP as END
FROM WORKFLOW_METADATA_SUMMARY_ENTRY
ORDER BY END_TIMESTAMP DESC
LIMIT 20;"

echo "Long duration"
mysql --host=127.0.0.1 --user=cromwell --password=test cromwell_test -e \
"SELECT WORKFlOW_NAME as name,
TIMESTAMPDIFF(MINUTE, START_TIMESTAMP, END_TIMESTAMP) as RUNTIME_MINUTES,
START_TIMESTAMP as start,
END_TIMESTAMP as end
FROM WORKFLOW_METADATA_SUMMARY_ENTRY
ORDER BY RUNTIME_MINUTES DESC
LIMIT 20;"
}

cromwell::build::exec_retry_function() {
local retried_function
local retry_count
Expand Down
4 changes: 3 additions & 1 deletion src/ci/bin/testCentaurHoricromtalPapiV2beta.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@ cromwell::build::assemble_jars
cromwell::build::build_cromwell_docker

cromwell::build::run_centaur \
-p 100 \
-p 500 \
-e localdockertest \
-e relative_output_paths \
-e relative_output_paths_colliding \
-e standard_output_paths_colliding_prevented \
-e papi_v2alpha1_gcsa \

cromwell::build::generate_code_coverage

cromwell::build::print_workflow_statistics
2 changes: 2 additions & 0 deletions src/ci/bin/testCentaurPapiV2beta.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ cromwell::build::run_centaur \
-e papi_v2alpha1_gcsa \

cromwell::build::generate_code_coverage

cromwell::build::print_workflow_statistics
6 changes: 3 additions & 3 deletions src/ci/resources/papi_v2beta_horicromtal_application.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
include "papi_v2beta_application.conf"

system.max-workflow-launch-count=1
system.new-workflow-poll-rate=10
system.max-concurrent-workflows=30
system.max-workflow-launch-count=10
system.new-workflow-poll-rate=1
system.max-concurrent-workflows=500
system.cromwell_id_random_suffix=false

# Turn off token logging to reduce log volume
Expand Down
Loading